[#346] Send MCV2_Bond creation fee in createStoryline frontend#347
Merged
realproject7 merged 1 commit intomainfrom Mar 19, 2026
Merged
[#346] Send MCV2_Bond creation fee in createStoryline frontend#347realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
Fetch creationFee() from MCV2_Bond dynamically and pass as value in the createStoryline write call. Display fee to user in the create form. Add value field to WriteCall interface. Fixes #346 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 19, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR fixes the mainnet creation-fee bug in the frontend by reading creationFee() from MCV2_Bond, passing it through the write call, and surfacing it in the create UI. The write path and local verification both check out.
Findings
- [info]
src/app/create/page.tsxnow fetchescreationFee()fromMCV2_Bondand passes it asvaluein thecreateStorylinewrite call, whileusePublishaccepts and forwards the optionalvaluefield.
Decision
Approve because the frontend now sends the required creation fee on mainnet and keeps testnet behavior compatible when the fee is zero.
project7-interns
approved these changes
Mar 19, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
- Dynamic
creationFee()fetch viauseQuerywith 1-min staleTime — correct, fee can change ✓ - Default
BigInt(0)— safe for testnet where fee is 0 ✓ value: creationFeepassed inbuildWriteCall✓- User-facing fee display (conditional on fee > 0) with
formatEther✓ WriteCallinterface extended with optionalvalue?: bigint✓- CI green (typecheck + build)
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
creationFee()dynamically from MCV2_Bond viauseQueryvalue: creationFeeinbuildWriteCallforcreateStorylinevaluefield toWriteCallinterface inusePublish.tsTest plan
npm run typecheckpassesnpm run buildpassesFixes #346
🤖 Generated with Claude Code